From owner-taylor-uucp@gnu.ai.mit.edu Tue Apr 28 03:36:02 1992
Status: RO
X-VM-v5-Data: ([nil nil nil nil nil nil nil nil nil]
	[nil nil nil nil nil nil nil nil nil nil nil nil "^From:" nil nil nil])
Received: from fuug.fi by dolphin.funet.fi with SMTP id AA12002
  (5.65c/IDA-1.4.3 for ojala); Tue, 28 Apr 1992 03:35:51 +0300
Received: from wookumz.gnu.ai.mit.edu by fuug.fi with SMTP id AA28240
  (5.65c/IDA-1.4.4 for <taylor-uucp-list@fuug.fi>); Tue, 28 Apr 1992 03:32:50 +0300
Received: by wookumz.gnu.ai.mit.edu (5.65/4.0)
	id <AA08111@wookumz.gnu.ai.mit.edu>; Mon, 27 Apr 92 20:05:12 -0400
Received: from relay2.UU.NET by wookumz.gnu.ai.mit.edu (5.65/4.0) with SMTP
	id <AA08107@wookumz.gnu.ai.mit.edu>; Mon, 27 Apr 92 20:05:09 -0400
Received: from uunet.uu.net (via LOCALHOST.UU.NET) by relay2.UU.NET with SMTP 
	(5.61/UUNET-internet-primary) id AA08529; Mon, 27 Apr 92 20:05:15 -0400
Received: from airs.UUCP by uunet.uu.net with UUCP/RMAIL
	(queueing-rmail) id 200450.11553; Mon, 27 Apr 1992 20:04:50 EDT
Received: by comton.airs.com (5.57/AIRS1.0)
	id AA02348; Mon, 27 Apr 92 18:57:14 -0400
Message-Id: <9204272257.AA02348@comton.airs.com>
In-Reply-To: <9204271513.AA00277@sanson.dit.upm.es>; from "Jose A. Manas" at Apr 27, 92 5:13 pm
X-Mailer: ELM [version 2.3 PL11]
From: ian@airs.com (Ian Lance Taylor)
To: pepe@dit.upm.es (Jose A. Manas)
Cc: taylor-uucp@gnu.ai.mit.edu
Subject: Re: bug in uux.c
Date: Mon, 27 Apr 92 18:57:12 -0400

Jose Manas writes:

> uux.c:
>    423  /* pepe@dit.upm.es 23/04/92
>    424            if (cargs >= calloc_args + 1)
>    425  */
>    426            if (cargs >= calloc_args)

Yup.  Sorry about that.  A very stupid blunder on my part.  The patch
should actually look like the following, as in certain cases cargs
will be incremented twice in the rest of the loop.

diff -c -r1.34 uux.c
*** 1.34	1992/04/22 23:29:24
--- uux.c	1992/04/27 22:53:53
***************
*** 426,432 ****
      {
        while (*zarg != '\0')
  	{
! 	  if (cargs >= calloc_args + 1)
  	    {
  	      calloc_args += 10;
  	      pzargs = (char **) xrealloc ((pointer) pzargs,
--- 426,432 ----
      {
        while (*zarg != '\0')
  	{
! 	  if (cargs + 1 >= calloc_args)
  	    {
  	      calloc_args += 10;
  	      pzargs = (char **) xrealloc ((pointer) pzargs,
-- 
Ian Taylor                     ian@airs.com                    uunet!airs!ian
First person to identify this quote wins a free e-mail message:
``Do you make a grievance of weighing so many pounds only, instead of three
  hundred?  Then why fret about living so many years only, instead of more?''

